Project

General

Profile

Actions

Bug #989

open

rk818 is spewing to console

Added by Hammel 11 months ago. Updated 11 months ago.

Status:
In Progress
Priority:
Immediate
Assignee:
Target version:
Start date:
19 May 2023
Due date:
% Done:

10%

Estimated time:
Severity:
02 - High

Description

The driver spews changes to the console:

rk818-bat: changed: dsoc=66, rsoc=69, v=3873, ov=4078 c=-412, cap=1862, f=2708, st=charge off, hotdie=0
rk818-bat: dl=81, rl=81, v=3972, halt=0, halt_n=0, max=0, init=0, sw=0, calib=0, below0=0, force=0

Need an option to disable those so the serial console isn't corrupted by them.

Actions #1

Updated by Hammel 11 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

This happens in power/supply/rk818_battery.c:rk818_bat_power_supply_changed() which calls BAT_INFO, which itself is a macro that calls pr_info() .

Seems reasonable to change the BAT_INFO macro to use pr_debug() so those messages are only enabled when debug is enabled.

Actions

Also available in: Atom PDF