Project

General

Profile

Actions
Copy link

Feature #910

closed

Add mutex to piboxLogger

Added by Hammel about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Immediate
Assignee:
Hammel
Target version:
PiBox - 3.0 - Corrino
Start date:
11 Oct 2022
Due date:
% Done:

100%

Estimated time:
Severity:
02 - High

Description

It would be helpful to have a mutex in the logger so that log messages are not intermixed from multiple threads.
This could slow things down but since logging is just for debugging it shouldn't be a big issue.

Actions
Copy link
 #1

Updated by Hammel over 1 year ago

  • Priority changed from Urgent to Immediate
  • Severity changed from 01 - Critical to 02 - High
Actions
Copy link
 #2

Updated by Hammel over 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20

Implemented but not tested.

Build piboxlib as an opkg and install on a node, then test with logging enabled on the launcher. This will require a build of the media system based on the new 3.0 dev system build.

Actions
Copy link
 #3

Updated by Hammel over 1 year ago

The media system doesn't build because monkey does not build (RM #1012). Player, pistore and pisentry also need monkey. Kiosk builds without monkey, so I can test with that.

Actions
Copy link
 #4

Updated by Hammel over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 20 to 100

Tested on hw with kiosk apps. Logs for all apps work as expected, including piboxd. Pipics, videofe and piboxd all have multiple threads and the logs were cleanly output for all of them.

Code is committed and pushed.

Closing issue.

Actions
Copy link

Also available in: Atom PDF