Project

General

Profile

Actions

Feature #742

closed

Boot cleanup

Added by Hammel over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Immediate
Assignee:
Category:
UI
Target version:
Start date:
29 Feb 2020
Due date:
% Done:

100%

Estimated time:
Severity:
05 - Very Low

Description

The following boot time display items should be cleaned up via pmsui.

  1. The blinking cursor (disabled with a config.txt option)
  2. Startup messages from
    1. S00dev
    2. S01psplash

The latter is probably a psplash change, not a pmsui change.

Actions #1

Updated by Hammel over 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

Item 1 was already done by RM #689. However, I had not rerun make HW=rpi2 rpifw-pkg to update the cmdline.txt in the package tree. So it looked like the fix wasn't available. It is now.

Here's the right way to handle quieting those init scripts.

  • new function - getQuiet() in functions.sh
    • Called when functions.sh is sourced
    • sets global ECHO="echo" if quiet is not found on command line
    • sets global ECHO="/bin/true" is quiet is found on command line
  • Update all init scripts to use $ECHO instead of shell "echo"
  • functions.sh should be sourced by rcS, not each script independently.

Using global variable sourced from functions.sh will be faster than a function call replacing echo (re: using log() intead of echo would be slower).

Actions #2

Updated by Hammel over 1 year ago

  • % Done changed from 10 to 30

I've implemented this in the function script including updating the log() function to not output to console if "quiet" is set on the kernel command line. function script is already being sourced by rcS which means all init scripts, which rcS sources, will have it set properly.

S00dev doesn't seem to echo anything, so the messages I was seeing must have been from the log() function.
S01psplash is updated but I think its console message was also from log().

All updates need to be tested. The changes are in rpi1 and in psplash.

Actions #3

Updated by Hammel over 1 year ago

  • % Done changed from 30 to 80

Verified working but I'm having problems with installation to the SD card. The overlay is not working for some reason. See RM #736.

Until I get the installs working again I need to keep this one open.

Actions #4

Updated by Hammel over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 80 to 100

Fixed, tested and verified working. Changes committed and pushed.

Closing issue.

Actions

Also available in: Atom PDF