Project

General

Profile

Actions

Bug #1092

closed

genModel if/then logic is incorrect

Added by Hammel 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Immediate
Assignee:
Category:
04 - Root File System
Target version:
Start date:
03 Jan 2024
Due date:
% Done:

100%

Estimated time:
Severity:
01 - Critical

Description

It uses grep -q and tests the rc. But this doesn't work correctly, or at least is used incorrectly.

The better (and tested) solution is to test if the grep returns anything, as in

if [ -z "$(grep MODEL /etc/pibox-version)" ]; then

This was on some of the boards I had but apparently didn't make into the source tree.

Actions #1

Updated by Hammel 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

Fixed. Tested on hardware.

Committed and pushed.

Closing issue.

Actions

Also available in: Atom PDF