Bug #714

omxplayer FIFO control is broken

Added by Hammel 11 months ago. Updated 11 months ago.

Status:ClosedStart date:15 Sep 2019
Priority:ImmediateDue date:
Assignee:Hammel% Done:

100%

Category:Runtime
Target version:PiBox - 2.0 - Harkonnen
Severity:01 - Critical

Description

I found this bug report from Aug 6, 2019 which suggests using something like dbuscontrol.sh to control omxplayer. I'll have to switch to that in videofe, although using the C interface would be even better. I can find no solution to the broken FIFO problem as of yet.

The solution, after some testing, is to use a modified version of dbuscontrol.sh. The original has some tests for files that don't exist and are not created by omxplayer (they are probably artifacts of Raspbian or a wrapper around omxplayer.bin) but those files aren't actually needed for my use case. So I can simplify the script and then call it from the player.c where I'm currently using the FIFO.

I'll need to rip out the FIFO stuff and replace it with calling the shell script.


Related issues

Blocks PiBox - Bug #712: Fix thread management in all apps Closed 26 Jun 2019

Associated revisions

Revision 719ae6d4
Added by Hammel 11 months ago

RM #714: Switch from FIFO to dbus control of omxplayer under touchscreen. Add missing SIGINT before shutting down touchscreen library otherwise the library doesn't shutdown until the timeout.

Revision e41b37fc
Added by Hammel 11 months ago

RM #714: Add missing dbuscontrol.sh script that didn't get added to last commit.

History

#1 Updated by Hammel 11 months ago

  • Priority changed from Normal to Immediate
  • % Done changed from 0 to 30
  • Severity changed from 03 - Medium to 01 - Critical

I've updated the code, which was easier than I thought - most of the changes go into msgPlayer() with a few checks to make sure that will work in main(). Code compiles. Now it needs testing on the kiosk.

#2 Updated by Hammel 11 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 30 to 100

Implemented and tested. Also added missing SIGINT to exit touchscreen library properly.
Code committed and pushed.
Closing issue.

Also available in: Atom PDF