Action Item #698

Add ShellCheck to validation of shell scripts

Added by Hammel over 1 year ago. Updated 10 months ago.

Status:ClosedStart date:10 Mar 2019
Priority:ImmediateDue date:
Assignee:Hammel% Done:

100%

Category:00 - Basic Build Issues
Target version:1.1.0 - Upgrades
Severity:05 - Very Low

Description

Just found ShellCheck (git) and it seems to find some interesting issues with mkinstall. Should probably run this against any scripts included in PiBox.

Associated revisions

Revision 88937036
Added by Hammel over 1 year ago

RM #698: Added target for running shellcheck against shell scripts used in both build and runtime. Fixed problems in mksd and mkinstall found by shellcheck.

Revision 30fe4b2c
Added by Hammel over 1 year ago

RM #698: Shellcheck updates. Removed duplicate bashsetup.sh.

Revision c3e59e43
Added by Hammel 10 months ago

RM #698: Run shellcheck processing on all skeleton scripts.

Revision ae7b4584
Added by Hammel 10 months ago

RM #698: Run shellcheck processing on all install scripts.

History

#1 Updated by Hammel over 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

Ran it on firstboot and cleaned it up.

#2 Updated by Hammel 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 10 to 100

Completed this today. The shellcheck tests runs cleanly for all configured shell scripts.

Also available in: Atom PDF