Action Item #698
Add ShellCheck to validation of shell scripts
| Status: | Closed | Start date: | 10 Mar 2019 | |
|---|---|---|---|---|
| Priority: | Immediate | Due date: | ||
| Assignee: |  Hammel | % Done: | 100% | |
| Category: | 00 - Basic Build Issues | |||
| Target version: | 1.1.0 - Upgrades | |||
| Severity: | 05 - Very Low |
Description
Just found ShellCheck (git) and it seems to find some interesting issues with mkinstall. Should probably run this against any scripts included in PiBox.
Associated revisions
RM #698: Added target for running shellcheck against shell scripts used in both build and runtime. Fixed problems in mksd and mkinstall found by shellcheck.
RM #698: Shellcheck updates. Removed duplicate bashsetup.sh.
RM #698: Run shellcheck processing on all skeleton scripts.
RM #698: Run shellcheck processing on all install scripts.
History
#1
Updated by Hammel almost 2 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 10
Ran it on firstboot and cleaned it up.
#2
Updated by Hammel about 1 year ago
- Status changed from In Progress to Closed
- % Done changed from 10 to 100
Completed this today. The shellcheck tests runs cleanly for all configured shell scripts.